You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When adding a new Instruction Group you need to change the following files: InstructionGroups.hh, ModelConfig.cc and Instruction.cc::getGroup(), adding repeated information. Numbering is required to be contiguous which combined with the base + offset methodology of getGroup enforces nonsensical groups e.g. FLOAT_SIMPLE_SHIFT or more complex checks to ensure these aren't returned by getGroup. Ideally, a new group would only need to be added in one file and nonsensical groups wouldn't be required.
The text was updated successfully, but these errors were encountered:
When adding a new Instruction Group you need to change the following files: InstructionGroups.hh, ModelConfig.cc and Instruction.cc::getGroup(), adding repeated information. Numbering is required to be contiguous which combined with the base + offset methodology of getGroup enforces nonsensical groups e.g. FLOAT_SIMPLE_SHIFT or more complex checks to ensure these aren't returned by getGroup. Ideally, a new group would only need to be added in one file and nonsensical groups wouldn't be required.
The text was updated successfully, but these errors were encountered: