Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Instruction Group Logic Closer Together and Simplify #347

Open
dANW34V3R opened this issue Nov 7, 2023 · 0 comments
Open

Pull Instruction Group Logic Closer Together and Simplify #347

dANW34V3R opened this issue Nov 7, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dANW34V3R
Copy link
Contributor

When adding a new Instruction Group you need to change the following files: InstructionGroups.hh, ModelConfig.cc and Instruction.cc::getGroup(), adding repeated information. Numbering is required to be contiguous which combined with the base + offset methodology of getGroup enforces nonsensical groups e.g. FLOAT_SIMPLE_SHIFT or more complex checks to ensure these aren't returned by getGroup. Ideally, a new group would only need to be added in one file and nonsensical groups wouldn't be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ToDo
Development

No branches or pull requests

1 participant