Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniBUDE output Error #202

Closed
FinnWilkinson opened this issue Nov 26, 2021 · 3 comments · Fixed by #352
Closed

miniBUDE output Error #202

FinnWilkinson opened this issue Nov 26, 2021 · 3 comments · Fixed by #352
Labels
bug Something isn't working

Comments

@FinnWilkinson
Copy link
Contributor

The miniBUDE benchmark has output error when compiling with ArmClang-v20 or GNU gcc-v10.3.0 targeting the armv8.4-a+sve architecture (OpenMP enabled with -fopenmp compilation flag).

Largest difference value for --deck bm1 -n 64 -i 1 compiling parameters should be 0.000%, however it is 0.405% for ArmClang-v20, and 48641.973% for GNU-v10.3.0.

Likely a slight issue with one or more SVE instructions.
@FinnWilkinson FinnWilkinson added the bug Something isn't working label Nov 26, 2021
@FinnWilkinson
Copy link
Contributor Author

GNU gcc10.3.0 now has the correct behaviour as of #230

@FinnWilkinson FinnWilkinson mentioned this issue Jan 17, 2024
Merged
@FinnWilkinson
Copy link
Contributor Author

PR #352 implements a fix for the Armclang issue

@FinnWilkinson FinnWilkinson linked a pull request Jan 29, 2024 that will close this issue
Unit Test Suite Update #352
Merged
FinnWilkinson added a commit that referenced this issue Feb 2, 2024
@FinnWilkinson
Unit Test Suite Update (#352)
f5e7aac 
This pull request aims to update the Unit test suite of SimEng such that all classes have comprehensive coverage of their functionality tested. Closes #340

No tests have been added / updated for the following classes due to radical changes / replacement in current Pull Requests or in the very near future:

CoreInstance
Soon to be removed/radically changed in near future
MicroDecoder
Logic should be tested via the MicroOperation.cc regression tests
All functions except decode (as of this PR) are now private - this change was made to conform to standard OOP practices; given they are only used within the class itself.
This PR also contains a fixes for issues #365, #202, #133.
@FinnWilkinson
Copy link
Contributor Author

Issue completed with PR #352 merged into dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit Test Suite Update UoB-HPC/SimEng
1 participant
@FinnWilkinson