Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISD dictionaries are not JSON serializable if the filename has a POSIX path #232

Closed
MthwRobinson opened this issue Feb 16, 2023 · 5 comments · Fixed by #233
Closed

ISD dictionaries are not JSON serializable if the filename has a POSIX path #232

MthwRobinson opened this issue Feb 16, 2023 · 5 comments · Fixed by #233
Assignees
@MthwRobinson
Labels
bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code

Comments

@MthwRobinson
Copy link
Contributor

Currently if a filename has a path like "../../my-file.txt", the ISD dictionary is not JSON serializable. The goal of this issue is to only include the filename and not the full path in the metadata so that the ISD dictionary is JSON serializable.
@MthwRobinson MthwRobinson added bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code labels Feb 16, 2023
@MthwRobinson MthwRobinson self-assigned this Feb 16, 2023
@MthwRobinson MthwRobinson mentioned this issue Feb 16, 2023
Merged
@firedragonironfist
Copy link
Contributor

Hi MthwRobinson, I'm a new contributor to this project and I'm currently working on this issue. I'm a bit stuck and not sure how to proceed to resolve the issue. Could you please provide me with some guidance on how to move forward? Any help would be greatly appreciated!

@MthwRobinson
Copy link
Contributor Author

Thanks @firedragonironfist for your interest in contributing! #233 will close this issue, but maybe checkout #228 if you'd like to make a first contribution. Just make sure to assign the issue to yourself so we know you're working on it.

@firedragonironfist
Copy link
Contributor

Thank you so much I will check it out

@MthwRobinson
Copy link
Contributor Author

Actually looks like we already had a taker on #228 . #208 would be another good first contribution issue

@MthwRobinson
Copy link
Contributor Author

Oh nevermind that was you! I think I misread the username. Just assigned you #228 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MthwRobinson MthwRobinson

Labels
bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ElementMetadata serializes when the filename is a Path object Unstructured-IO/unstructured
2 participants
@MthwRobinson @firedragonironfist