2023.1: Crash on malloc_internal when recompiling a ShaderGraph used by another shader via UsePass

skeshri-rythmos · Evergreen · commit 48388ea8849c · 2023-11-06T10:55:38.000Z
Issue here is that Crash on malloc_internal when recompiling a ShaderGraph used by another shader via UsePass This PR fixes the issues by making sure that shaders are reloaded after all shader import cases. Bug: https://jira.unity3d.com/browse/UUM-46187 Backport: https://jira.unity3d.com/browse/UUM-48112
diff --git a/Tests/SRPTests/Projects/ShaderGraph/Assets/CommonAssets/Editor/FileMoveTests.cs b/Tests/SRPTests/Projects/ShaderGraph/Assets/CommonAssets/Editor/FileMoveTests.cs
@@ -195,6 +195,12 @@ public IEnumerator MoveDirectoryTests()
             yield return null;
 
             CloseGraphWindow();
+
+            // Wait for any potential compilation to finish before entering cleanup, which deletes the files
+            while (ShaderUtil.anythingCompiling)
+            {
+                yield return null;
+            }
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -195,6 +195,12 @@ public IEnumerator MoveDirectoryTests()`
`195`	`195`	`yield return null;`
`196`	`196`
`197`	`197`	`CloseGraphWindow();`
	`198`	`+`
	`199`	`+ // Wait for any potential compilation to finish before entering cleanup, which deletes the files`
	`200`	`+ while (ShaderUtil.anythingCompiling)`
	`201`	`+ {`
	`202`	`+ yield return null;`
	`203`	`+ }`
`198`	`204`	`}`
`199`	`205`	`}`
`200`	`206`	`}`