Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PositionValue may suffer from underflow in 0.8 version #383

Open
jes16jupyter opened this issue Apr 16, 2024 · 0 comments
Open

PositionValue may suffer from underflow in 0.8 version #383

jes16jupyter opened this issue Apr 16, 2024 · 0 comments

Comments

@jes16jupyter
Copy link

Hi, according to #198, the solc version of PositionValue is restricted below 0.8.0, as fee calculation code relies on unchecked math that is expected to overflow. Current implementation is pragma solidity >=0.6.8 <0.8.0;.

But in 0.8 branch, PositionValue has no unchecked nor the code is altered, but the version 0.8.0 is included.

Thus unexpected revert will happen as I am understanding it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant