From 3df7d515381d7a54b2a4ea49a6126ca76efa1389 Mon Sep 17 00:00:00 2001 From: Hanne Moa Date: Fri, 8 Nov 2024 14:47:57 +0100 Subject: [PATCH 1/3] Mark theme_dropdown.html as partial --- src/argus_htmx/templates/htmx/base.html | 2 +- .../htmx/themes/{theme_dropdown.html => _theme_dropdown.html} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename src/argus_htmx/templates/htmx/themes/{theme_dropdown.html => _theme_dropdown.html} (100%) diff --git a/src/argus_htmx/templates/htmx/base.html b/src/argus_htmx/templates/htmx/base.html index 8ffc0bc0..3b366edb 100644 --- a/src/argus_htmx/templates/htmx/base.html +++ b/src/argus_htmx/templates/htmx/base.html @@ -43,7 +43,7 @@ Logged in as: {{ request.user }}
-
  • {% include "htmx/themes/theme_dropdown.html" %}
  • +
  • {% include "htmx/themes/_theme_dropdown.html" %}
  • {% include "htmx/dateformat/_dateformat_dropdown.html" %}
  • Preferences… diff --git a/src/argus_htmx/templates/htmx/themes/theme_dropdown.html b/src/argus_htmx/templates/htmx/themes/_theme_dropdown.html similarity index 100% rename from src/argus_htmx/templates/htmx/themes/theme_dropdown.html rename to src/argus_htmx/templates/htmx/themes/_theme_dropdown.html From cab17aec3f5e9e2de7b68f0d0e50a0b8dda50f59 Mon Sep 17 00:00:00 2001 From: Hanne Moa Date: Fri, 8 Nov 2024 15:00:40 +0100 Subject: [PATCH 2/3] Mark theme_list.html as partial --- .../templates/htmx/themes/{theme_list.html => _theme_list.html} | 0 src/argus_htmx/themes/views.py | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename src/argus_htmx/templates/htmx/themes/{theme_list.html => _theme_list.html} (100%) diff --git a/src/argus_htmx/templates/htmx/themes/theme_list.html b/src/argus_htmx/templates/htmx/themes/_theme_list.html similarity index 100% rename from src/argus_htmx/templates/htmx/themes/theme_list.html rename to src/argus_htmx/templates/htmx/themes/_theme_list.html diff --git a/src/argus_htmx/themes/views.py b/src/argus_htmx/themes/views.py index 8954cf09..a5116c48 100644 --- a/src/argus_htmx/themes/views.py +++ b/src/argus_htmx/themes/views.py @@ -35,7 +35,7 @@ def post(self, request, *args, **kwargs): @require_GET def theme_names(request: HtmxHttpRequest) -> HttpResponse: themes = THEME_NAMES - return render(request, "htmx/themes/theme_list.html", {"theme_list": themes}) + return render(request, "htmx/themes/_theme_list.html", {"theme_list": themes}) @require_POST From 854872671f7e3d86788364820d16ea1887f83d91 Mon Sep 17 00:00:00 2001 From: Hanne Moa Date: Fri, 8 Nov 2024 15:01:49 +0100 Subject: [PATCH 3/3] Remove unused view --- .../templates/htmx/themes/themes_list.html | 22 ------------------- src/argus_htmx/themes/urls.py | 1 - src/argus_htmx/themes/views.py | 19 +--------------- 3 files changed, 1 insertion(+), 41 deletions(-) delete mode 100644 src/argus_htmx/templates/htmx/themes/themes_list.html diff --git a/src/argus_htmx/templates/htmx/themes/themes_list.html b/src/argus_htmx/templates/htmx/themes/themes_list.html deleted file mode 100644 index 9b53644b..00000000 --- a/src/argus_htmx/templates/htmx/themes/themes_list.html +++ /dev/null @@ -1,22 +0,0 @@ -{% extends "htmx/base.html" %} -{% block main %} -
    -

    Switch theme

    - {% if preferences.argus_htmx.theme %} -

    Theme is set to: {{ preferences.argus_htmx.theme }}

    - {% else %} -

    No theme set

    - {% endif %} -
      - {% for item in object_list %} -
    • -
      - {% csrf_token %} - - -
      -
    • - {% endfor %} -
    -
    -{% endblock main %} diff --git a/src/argus_htmx/themes/urls.py b/src/argus_htmx/themes/urls.py index 87d96469..267667b8 100644 --- a/src/argus_htmx/themes/urls.py +++ b/src/argus_htmx/themes/urls.py @@ -5,7 +5,6 @@ app_name = "htmx" urlpatterns = [ - path("", views.ThemeListView.as_view(), name="theme-list"), path("names/", views.theme_names, name="theme-names"), path("change/", views.change_theme, name="change-theme"), ] diff --git a/src/argus_htmx/themes/views.py b/src/argus_htmx/themes/views.py index a5116c48..9a21c3b0 100644 --- a/src/argus_htmx/themes/views.py +++ b/src/argus_htmx/themes/views.py @@ -1,10 +1,9 @@ import logging from django.shortcuts import render -from django.views.generic import ListView from django.views.decorators.http import require_GET, require_POST -from django.http import HttpResponse, HttpResponseRedirect +from django.http import HttpResponse from django_htmx.http import HttpResponseClientRefresh from argus.auth.utils import get_preference, save_preference @@ -16,22 +15,6 @@ THEMES_MODULE = "argus_htmx" -class ThemeListView(ListView): - http_method_names = ["get", "post", "head", "options", "trace"] - template_name = "htmx/themes/themes_list.html" - - def setup(self, request, *args, **kwargs): - super().setup(request, *args, **kwargs) - self.themes = THEME_NAMES - - def get_queryset(self): - return self.themes - - def post(self, request, *args, **kwargs): - save_preference(request, request.POST, "argus_htmx", "theme") - return HttpResponseRedirect("") - - @require_GET def theme_names(request: HtmxHttpRequest) -> HttpResponse: themes = THEME_NAMES