-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation is impossible on mobile #811
Comments
Oh no! In the past it worked fine. I’ve used the mobile version before and the website was usable. I also noticed that when you search for something you get a screen with file titles and lists of content creators: It would probably be more useful if we would display a portion of the Idea section there |
Interesting. I can reproduce the behavior, but that must be a recent thing, because even last week I used my phone to look at the website and everything was alright. I'll try to track it down and fix it. |
I'm not sure how much influence we have over these results; we're using mdbook's search feature, which delegates to a third party library. I was already thinking that the results could be more useful, but I don't have a concrete proposal, and in the worst case we'd have to reimplement the search ourselves, which TBH isn't something I'd like to spend time on right now. |
Fair enough:) |
Update: I'm pretty sure it's caused by this change in mdbook rust-lang/mdBook#2175. It changed some default assets which we're overriding, so I'll try to port them over and see if it fixes the issue. I'll pin the versions of mdbook and the other mdbook- packages in the installation script and in the CI, so that things like this don't happen in the future. |
Well done for finding what caused the issue! But is pinning a version of |
Well nothing prevents us from updating the pinned version in the future, but it will be our choice. Currently I'd bet there is even a discrepancy between the CI version of The status quo is the worst of both worlds - we have no control over the version of |
Alright! Let's pin the version ot 4.34 then:) |
I'm on it 👌 |
The previous PR didn't actually fix the issue, the new one #819 should. |
Thank you for resolving the main issue, @VojtechStep! However, I'd like to note that the navigation buttons on the bottom of the webpage still don't seem to work. I'll open a new issue for that, and I don't think it is as pressing as the issue you resolved previously. |
So I was having a quick look at our website this morning on my phone, and at first I noticed this button at the bottom that doesn't go anywhere:
Then I tried to use the side bar, but apparently it doesn't display:
Same in Chrome:
The text was updated successfully, but these errors were encountered: