Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn ros_comm customizations into a separate package? #1

Open
peci1 opened this issue Jun 14, 2022 · 0 comments
Open

Turn ros_comm customizations into a separate package? #1

peci1 opened this issue Jun 14, 2022 · 0 comments

Comments

@peci1
Copy link

peci1 commented Jun 14, 2022

Hi, your customization regarding a more efficient index for rosbags looks definitely very interesting. However, using a fork of ros_comm is problematic for most users, as it is harder to get updates from upstream. Do you think it'd be possible to make the changes in a separate package, e.g. rosbag_fast or a similar name? The Python part should be quite easy as it should be sufficient to monkey-patch the original rosbag functions you need to change.

The C++ part might be problematic, but there could possibly be a solution (as a possible workaround I can see for example that the index file would report itself as rosbag version 99 or so, and would contain a link to the original bag file, and if you'd like to open the bag with the fast index, you would pass just the index file, rosbag would open it and read with a reader for version 99, and internally it would read the fast index and open the original bag file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant