Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring for deprecated components #27

Open
zanechua opened this issue Jan 30, 2020 · 1 comment
Open

Code refactoring for deprecated components #27

zanechua opened this issue Jan 30, 2020 · 1 comment

Comments

@zanechua
Copy link

First off, I have to say great package.

Would you guys be open to merge in a huge merge request with a ton of code refactoring changes?

The code refactoring would solve some of the issues here with regards to the height of the toolbar plus updates for RN0.6x and above to ensure they work with the newer <SectionList> component.

My fork is currently at : https://github.com/zanechua/react-native-search-list/commits/master
@erichua23
Copy link
Member

Welcome!
You can create a PR first. We will review it and discuss with you if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erichua23 @zanechua