Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] #AUDIO as alternative to #MP3 to specify audio file #21

Closed
achimmihca opened this issue Sep 16, 2023 · 6 comments
Closed

[Spec] #AUDIO as alternative to #MP3 to specify audio file #21

achimmihca opened this issue Sep 16, 2023 · 6 comments
Labels
approved Consent from majority new feature New feature or request v1.1.0 (2023) implement in v1.1.0 (2023)

Comments

@achimmihca
Copy link

Suggestion

Historically, the #MP3 header field is used to specify the audio file.

However, mp3 files are not the only supported audio format.

Thus, one could argue that #AUDIO would be a better name for the field.

But this could only be done as an alternative to #MP3 to not break compatibility with the thousands of existing txt files.

So there is no clear winner:

  • On the one hand, #MP3 is a misleading name for the header field.
  • On the other hand, two header fields with the same purpose might also be confusing.

What do you think?

Use case

For newbies and tutorials, it might be more intuitive to use and show #AUDIO instead of #MP3.
But it is only a minor issue.

Extra info/examples/attachments

No response

@bohning
Copy link
Collaborator

bohning commented Sep 16, 2023

I would favor the support for #AUDIO (in addition to #MP3 for backwards compatibility). If USDX and others implement support, they could convert #MP3 to #AUDIO on save. The Syncer could convert it as well, but ideally usdb would support it as well so that it’s adoption spreads.

(related: why not use #VOCALS and #INSTRUMENTAL instead of the longer #VOCALAUDIO and #INSTRUMENTALAUDIO?)

@marwin89 marwin89 added the improvement Improvement of a existing feature label Sep 17, 2023
@marwin89 marwin89 added backlog v1.1.0 (2023) implement in v1.1.0 (2023) labels Sep 21, 2023
@marwin89 marwin89 changed the title #AUDIO as alternative to #MP3 to specify audio file [Spec] #AUDIO as alternative to #MP3 to specify audio file Sep 23, 2023
@rakuri255
Copy link
Collaborator

#VOCALS makes no sense to me. It's just #AUDIO, #MUSIC, #AUDIOFILE.
For Karaoke #INSTRUMENTAL, #KARAOKE or #KARAOKEAUDIO would be nice

@achimmihca
Copy link
Author

#VOCALS makes no sense to me

This discussion has its own issue: #20

Please use this issue here only for "#AUDIO as alternative to #MP3".

@marwin89
Copy link
Collaborator

marwin89 commented Oct 4, 2023

Thanks for your discussion. So we have a consens here. ✅

I've put #AUDIO to the Overview Version spreadsheet mentioned in #31 .

@marwin89 marwin89 closed this as completed Oct 4, 2023
@Baklap4
Copy link
Collaborator

Baklap4 commented Oct 4, 2023

Lets write a conclusion as the completed message so it doesnt get lost in translation :)

@marwin89
Copy link
Collaborator

marwin89 commented Oct 5, 2023

SUMMARY / FINAL RESULTS 🏁

So here are the final results for this issue.

We add this tag in version 1.1.0:

#AUDIO: Artist - Title of the song.mp3

We deprecate this tag in version 1.1.0:

#MP3: Artist - Title of the song.mp3

#MP3-Tag will be removed in version 2.0.0 (probably in 1-2 years).

The description in the spec (website) is:

#AUDIO
Definies the audio file that contains the whole music in one (consisting of VOCALS (the singers voice(s)) and INSTRUMENTAL(S). This is the new tag for the deprecated #MP3 tag.

@marwin89 marwin89 added approved Consent from majority new feature New feature or request and removed backlog improvement Improvement of a existing feature labels Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Consent from majority new feature New feature or request v1.1.0 (2023) implement in v1.1.0 (2023)
Projects
Development

No branches or pull requests

5 participants