Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tool] Visual Studio Code Plugin, Language Server, and Grammar #18

Open
achimmihca opened this issue Sep 15, 2023 · 3 comments
Open

[Tool] Visual Studio Code Plugin, Language Server, and Grammar #18

achimmihca opened this issue Sep 15, 2023 · 3 comments
Labels
new feature New feature or request

Comments

@achimmihca
Copy link

Suggestion

It would be nice to have a VisualStudio Code plugin for the UltraStar txt file format.

  • The plugin could suggest available header fields defined by this format.
  • The plugin could highlight errors in the format, e.g., overlapping notes, out of order notes
  • The plugin could suggest improvements, e.g., adding golden notes

Support for a new language in Visual Studio Code (and many other IDEs) can be added via a Language Server.

Grammar of the Format

Use case

People editing the format by hand in text editor could use the VisualStudio Code plugin.

Extra info/examples/attachments

No response

@marwin89 marwin89 added new feature New feature or request consent? labels Sep 17, 2023
@marwin89 marwin89 changed the title Visual Studio Code Plugin, Language Server, and Grammar [Tool] Visual Studio Code Plugin, Language Server, and Grammar Sep 23, 2023
@Baklap4
Copy link
Collaborator

Baklap4 commented Oct 4, 2023

Would be a really nice addition, but i doubt people are opening the txt files within VSCode that much (at least not your average player)

The plugin could suggest available header fields defined by this format.

Yes love this. Including some documentation about the field or note.

The plugin could highlight errors in the format, e.g., overlapping notes, out of order notes

That'd be really nice! This helps spotting errors early on. Not sure if possible, but implement this checking also on txt-upload

The plugin could suggest improvements, e.g., adding golden notes

Yes things get forgotten, so suggesting improvements is really nice.

Just a question would it be possible to store this in a library or something so creator software can also use this instead of just VSCode?

@achimmihca
Copy link
Author

would it be possible to store this in a library or something so creator software can also use this instead of just VSCode

Yes, by implementing the language server protocol it is editor agnostic (see illustration)

@marwin89 marwin89 removed the consent? label Oct 7, 2023
This was referenced Jan 29, 2024
@codello
Copy link
Contributor

codello commented Feb 10, 2024

#48 includes a first proposal for a grammar (in ABNF). There are still some open questions about some edge cases but it‘s a start.

I like the idea of having more tooling around the file format but I‘m not sure it would be in scope for this project. Maybe having a VS code plugin and a language server be separate projects would be a better fit?

@Baklap4 Baklap4 mentioned this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Development

No branches or pull requests

4 participants