Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non Ascii characters wrong in Windows installer #878

Open
Rumbah2 opened this issue Jul 28, 2024 · 2 comments
Open

Non Ascii characters wrong in Windows installer #878

Rumbah2 opened this issue Jul 28, 2024 · 2 comments

Comments

@Rumbah2
Copy link

Rumbah2 commented Jul 28, 2024

Actual behaviour

At least with German language, the windows installer of USDX does not display Umlauts correctly. They are just black boxes with a question mark inside.

Unbenannt

Expected behaviour

The Umlauts are displayed correctly, like äöüßÄÖÜ

Steps to reproduce

  1. Start the installer of USDX 2024.5.1 for Windows on a German Windows 11
  2. You can see the wrong Umlauts

Details

Provide some additional information:

  • USDX version: 2024.5.1 Windows installer
  • Operating System + version: Windows 11
@barbeque-squared
Copy link
Member

These texts are coming from https://github.com/UltraStar-Deluxe/USDX/blob/master/installer/languages/German.nsh#L78 where they do have umlauts.

Iirc I cannot debug/run the installer at all on my Windows PC.

(if it was only one or two I'd probably just 'fix' it by changing the words to not have special characters, but they're all throughout the installer and I have a suspicion this might also affect other languages then)

@DeinAlptraum
Copy link
Contributor

It seems our installer is missing the Unicode true flag, but adding it produces a broken installer (Unable to elevate) ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants