Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included config.ini is different from auto-generated config.ini #872

Open
barbeque-squared opened this issue Jul 21, 2024 · 0 comments
Open

Comments

@barbeque-squared
Copy link
Member

USDX ships with a config.ini

This works fine for Windows installations, except if someone deletes their config.ini and ends up getting the other defaults from UIni.pas. I don't know if other platforms even bother with the default config at all in the first place.

The biggest difference is in the way lyrics are displayed, but there's other differences as well.

I propose two things:

  1. we make config.ini and UIni.pas use the same values.
  2. why do we even ship a config.ini?

Current differences and my proposed defaults:

Setting git config.ini UIni.pas default proposed default
Game.Players 6 1 ???
Game.Sorting Artist Edtion ???
Graphics.Fullscreen Off Borderless ???
Graphics.Oscilloscope On Off On
Sound.PreviewVolume 70% 50% 50% or less
Lyrics.LyricsStyle Outline Regular Outline
Record.MicBoost +12dB Off Off
Record.Threshold 15% 10% ???
Jukebox.LyricsStyle Outline Regular Outline
Jukebox.LyricsEffect Slide Zoom Slide
Jukebox.LyricsAlpha 0.90 1.00 1.00
Jukebox.SingLineColor FFFF00 0096FF ???
Jukebox.NextLineColor D6D6D6 C0C0C0 ???
Name.P1 USDXstyle Player1 Player1
PlayerColor.P2 4 2 4
PlayerColor.P4 2 4 2

Notes

  • Game.Sorting: I'm biased towards Edition but I've been using that since forever.
  • Jukebox: I've been using SingLine FFFF00 + NextLine C0C0C0 since forever. C0C0C0 is fine imo, SingLine is the interesting one. I'm going to assume blue is a better choice wrt specific types of color blindness, however, especially with outline it should be a much lighter blue than 0096FF is. The tint is fine, but probably more towards rgb(71,179,255) or maybe even rgb(122,200,255).
  • The bizarre PlayerColor order is actually correct. This makes P2 = Yellow and P4 = Red. The reason for this is that Duets (currently -- why ARE we coloring them anyway?) use the player colors for the SingLineColor, and Red is way too dark for that. Already-sung lyrics become near-unreadable.

Obviously none of these changes are going to affect people that already have USDX set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant