Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch song list dynamically in Companion App #446

Open
achimmihca opened this issue Jun 28, 2024 · 1 comment
Open

Fetch song list dynamically in Companion App #446

achimmihca opened this issue Jun 28, 2024 · 1 comment

Comments

@achimmihca
Copy link
Collaborator

Actual behaviour

Currently, when the Companion App requests the song list, then all currently loaded songs are sent in the response. Afterwards, filtering is done locally on the Companion App.

This approach has some drawbacks:

  • bad performance for huge song libraries
  • inconsistent filtering compared to the main game
  • no dynamic search for songs possible, e.g., when integrating a song service or database (e.g. via some mod).

Expected behaviour

The song list should be fetched dynamically and filtering should be done by the main game (which is the server in this scenario).
This includes pagination for huge song libraries.

@achimmihca
Copy link
Collaborator Author

achimmihca commented Jun 28, 2024

This should make some issues obsolete that users reported with respect to search on Companion App:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant