Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending to different camera models #936

Open
Trzyq0712 opened this issue Oct 15, 2024 · 0 comments
Open

Extending to different camera models #936

Trzyq0712 opened this issue Oct 15, 2024 · 0 comments

Comments

@Trzyq0712
Copy link

I was trying to extend ORB_SLAM3 to use a different camera model - Omni. However, I have faced a few issues while trying to implement.

  • It is not really explained what some of the functions should do. Especially the following functions: epipolarConstrain, mathAndtriangulate, reconstructWithTwoViews.
  • When I guessed what they should do, or just hardcoded them to return true or false, the examples I had would not really run (monocular) - they would start but pretty much fail to do any matches between frames.
  • When I plugged the Omni model params into KannalaBrandt model, it wouldn't be accuarate but at least it would find matches.
  • I then snooped around the code more and found references to the specific camera models (Pinhole, KannalaBrandt). This makes the code not really modular as the rest of the code stores enums of the camera type, or refers directly to a specific type (src/Frame.cc, src/Setting.cc, src/Tracking.cc, src/Atlas.cc). I now need to understand what the code does in those places (very hard as there is barely any documentation) in order to make my camera model work.

Help would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant