Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting warnings during startup and usage of addon in v3 beta #186

Open
laddi-netapp opened this issue Aug 24, 2023 · 3 comments
Open

Getting warnings during startup and usage of addon in v3 beta #186

laddi-netapp opened this issue Aug 24, 2023 · 3 comments

Comments

@laddi-netapp
Copy link

laddi-netapp commented Aug 24, 2023

I'm using 3.0.0-beta-5 and I get two different warnings during startup/usage:

The first one immediately after opening Storybook:

storybook-design-token was loaded twice, this could have bad side-effects
warn @ chunk-6KNXZZZ5.js:1
AddonStore.register @ chunk-UBXIQABM.js:53
(anonymous) @ EasingPresenter.tsx:11

The other one shows up when opening a story:

Warning: The final argument passed to useMemo changed size between renders. The order and size of this array must remain constant.

Previous: [storybook/a11y/panel, storybook/a11y/panel, addon-controls, storybook/actions/panel, storybook-design-token/panel]
Incoming: [storybook/a11y/panel, storybook/a11y/panel, addon-controls, storybook/actions/panel]

Also, setting parameters: { designToken: { disable: true } } } doesn't seem to work in v3.x. The tab is shown (along with the error above) and when I click the tab, nothing happens and the tab is then removed. It will reappear if I do a reload of the browser window.

@laddi-netapp laddi-netapp changed the title Getting a Getting warnings during startup and usage of addon Aug 24, 2023
@laddi-netapp laddi-netapp changed the title Getting warnings during startup and usage of addon Getting warnings during startup and usage of addon in v3 beta Aug 24, 2023
@lukethacoder
Copy link

I wonder if this is similar to storybookjs/addon-styling#80

Looks like in addon-styling they simply removed the managerEntries export from the preset.ts file. (ref)?

export function managerEntries(entry: any[] = []) {
return [...entry, require.resolve("./manager")];
}

@Sqrrl
Copy link
Collaborator

Sqrrl commented Nov 9, 2023

I'm looking into the warnings. See #189 for the "disable" parameter.

@baspin94
Copy link

Hi there! I came across this open issue while trying to figure out why I was getting the storybook-design-token was loaded twice, this could have bad side-effects error in my console. (I'm using 3.1.0.)

Have there been any developments since November related to these warnings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants