Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when xlro is run on a dataset which has no catalog, it appears to break (but doesn't) #7

Open
spikelynch opened this issue Jul 10, 2020 · 1 comment
Open

when xlro is run on a dataset which has no catalog, it appears to break (but doesn't) #7

spikelynch opened this issue Jul 10, 2020 · 1 comment

Comments

@spikelynch
Copy link
Contributor

Throws a big noisy 'uncaught promises' backtrace when it can't find the ro-crate-metadata.json
@spikelynch
Copy link
Contributor Author

This is not what I thought it was. When you run it on a directory with no metadata or spreadsheet, it should

  • traverse the file system and build the spreadsheet and json, and then
  • use the metadata to build the HTML preview

I think the backtrace is being caused by an order-of-execution bug where the second of these steps is happening before the json file has been written out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spikelynch