Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot should post to talk page under a new section #150

Open
Pix1234 opened this issue Jul 14, 2018 · 1 comment
Open

Bot should post to talk page under a new section #150

Pix1234 opened this issue Jul 14, 2018 · 1 comment
Assignees

Comments

@Pix1234
Copy link

Pix1234 commented Jul 14, 2018

Instead of doing adding messages to talk pages like this: diff. Do this instead (diff)

@Salvidrim
Copy link
Contributor

Something must have changed, because I remember making the same argument in the BRFA and it was decided that the bot was going to add section headers:

It's pretty cool, but right now, if you click edit to edit the request, instead, it attempts to edit the template. --jpgordon::==( o ) 11:43 pm, 12 May 2016, Thursday (2 years, 2 months, 3 days ago) (UTC−4)

That's because the template is transcluded (not substed) and the header is part of the template; thus, the section edit link tries to edit the template's own section. This could be resolved by either substing (already discussed above), or making the bot create a new header on the talk page under which it would transcluded the headerless template. ☺ · Salvidrim! · ✉ 11:51 pm, 12 May 2016, Thursday (2 years, 2 months, 3 days ago) (UTC−4)

I've gone with the second option. I'm pushing the change to alpha right now, and I'll push it to live if it works without problems.--v/r - TP 2:43 am, 13 May 2016, Friday (2 years, 2 months, 3 days ago) (UTC−4)

and I thought I remembered it doing that already as per TP... but I've just spot-checked the bot's contribs all the way back to June 2016 and I see it has not been adding section headers, as far as I can see it never did. At least the template contents was changed to be headerless itself so as to avoid the initial problem of having an "edit section" link which led to editing the template itself due to transclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants