Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Move letter grade math to calculateGrades func #294

Open
TyHil opened this issue Oct 30, 2024 · 2 comments · May be fixed by #301
Open

[Internal] Move letter grade math to calculateGrades func #294

TyHil opened this issue Oct 30, 2024 · 2 comments · May be fixed by #301
Assignees
@AbhiramTadepalli
Labels
Good First Issue Good for newcomers Type: Internal Chore tasks that are needed for other features

Comments

@TyHil
Copy link
Member

TyHil commented Oct 30, 2024

Overview of Proposed Changes

Instead of recalculating the letter grade based on the GPA in the searchResultsTable component, store this data like the gpa is stored in calculateGrades.

Details

Changes are needed in and searchResultsTable the dashboard

Reference Skedge for an example:
https://github.com/UTDNebula/skedge/blob/bd999e5ea43893e600aef44f6110e62a0a79796c/src/pages/index.tsx#L86-L93
@TyHil TyHil added Type: Internal Chore tasks that are needed for other features Good First Issue Good for newcomers labels Oct 30, 2024
@AbhiramTadepalli AbhiramTadepalli self-assigned this Nov 11, 2024
@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Nov 11, 2024 •
edited
Loading

@TyHil Is what I did in bc04095 fine?

@TyHil
Copy link
Member Author

TyHil commented Nov 11, 2024

Yeah, that works!

@TyHil TyHil linked a pull request Nov 11, 2024 that will close this issue
bg of filter changes when filter is selected #301
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhiramTadepalli AbhiramTadepalli

Labels
Good First Issue Good for newcomers Type: Internal Chore tasks that are needed for other features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bg of filter changes when filter is selected UTDNebula/utd-trends
2 participants
@TyHil @AbhiramTadepalli