Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Auto update new courses in autocomplete graph #270

Open
1 task done
jpahm opened this issue Oct 22, 2024 · 11 comments · May be fixed by #302
Open
1 task done

[Bug]: Auto update new courses in autocomplete graph #270

jpahm opened this issue Oct 22, 2024 · 11 comments · May be fixed by #302
Assignees
Labels
Type: Bug Report Issues pertaining to non-security-related issues

Comments

@jpahm
Copy link

jpahm commented Oct 22, 2024

What did you expect to happen?

The ability to search for new courses from the current (24f) semester, i.e. ECS 2390.

What happened?

The course cannot be searched and isn't provided via autocomplete despite the course data being present in the API.

Version

Beta 0.1.0

What browsers are you seeing the problem on?

Firefox

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jpahm jpahm added the Type: Bug Report Issues pertaining to non-security-related issues label Oct 22, 2024
@jpahm
Copy link
Author

jpahm commented Oct 22, 2024

Note that a good long-term solution for this sort of issue will probably involve setting up a system to pull the latest DAG data from the API's autocomplete endpoint and generating the associated autocomplete graphs.

@TyHil
Copy link
Member

TyHil commented Oct 22, 2024

Ah I didn't know the autocomplete endpoint was functional, I'll work on that

@TyHil TyHil self-assigned this Oct 22, 2024
@TyHil TyHil added the Status: On Hold This has been delayed for a future sprint or release label Oct 22, 2024
@TyHil
Copy link
Member

TyHil commented Oct 22, 2024

On hold until the API endpoint is deployed

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Oct 22, 2024

@TyHil when someone searches for ECS 2390, should we display ECS 3390 distribution data?
and @jpahm when we call for ECS2390 grade distribution data, does API provide 3390 data from past semesters (also is there 2390 grade data yet)?

@TyHil
Copy link
Member

TyHil commented Oct 22, 2024

Idk, might be a little misleading to display 3390 data for 2390 since there have probably been some class changes. Hopefully people would know to look up 3390, but the fact they have to do that would indicate it is different from 2390.

@TyHil
Copy link
Member

TyHil commented Oct 22, 2024

This issue is blocked by nebula-api/#225

@TyHil when someone searches for ECS 2390, should we display ECS 3390 distribution data? and @jpahm when we call for ECS2390 grade distribution data, does API provide 3390 data from past semesters (also is there 2390 grade data yet)?

This is blocked by nebula-api/#223

@AbhiramTadepalli
Copy link
Contributor

Idk, might be a little misleading to display 3390 data for 2390 since there have probably been some class changes. Hopefully people would know to look up 3390, but the fact they have to do that would indicate it is different from 2390.

When UTDNebula/nebula-api#223 is completed, it will in fact group ECS 2390 and ECS 3390.

Now, we could detect the change maybe and let users know the course name has changed? That requires that the course API also groups by internal_course_number

@TyHil
Copy link
Member

TyHil commented Oct 22, 2024

If API is doing the grouping, seems reasonable to just do that then

@TyHil TyHil changed the title [Bug]: New courses missing from search due to outdated autocomplete graph [Bug]: Auto update new courses in autocomplete graph Oct 22, 2024
@mikehquan19
Copy link

Hi! I'm the one in charge of UTDNebula/nebula-api#223. The task will be completed by the end of Friday at the latest, and the issue with grouping will be resolved.

@jpahm
Copy link
Author

jpahm commented Oct 23, 2024

We could probably look into making the grouping optional if such functionality would be preferred.

@jpahm
Copy link
Author

jpahm commented Nov 4, 2024

This issue is blocked by nebula-api/#225

@TyHil when someone searches for ECS 2390, should we display ECS 3390 distribution data? and @jpahm when we call for ECS2390 grade distribution data, does API provide 3390 data from past semesters (also is there 2390 grade data yet)?

This is blocked by nebula-api/#223

Both of these are now unblocked via the latest API deployment :)

@TyHil TyHil removed the Status: On Hold This has been delayed for a future sprint or release label Nov 4, 2024
@TyHil TyHil linked a pull request Nov 4, 2024 that will close this issue
@TyHil TyHil linked a pull request Nov 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Report Issues pertaining to non-security-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants