Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCRA Management Method Codes #338

Open
5 tasks
Tracked by #249
dpgraham4401 opened this issue Feb 16, 2023 · 0 comments
Open
5 tasks
Tracked by #249

RCRA Management Method Codes #338

dpgraham4401 opened this issue Feb 16, 2023 · 0 comments
Labels
database changes that require modification to the database schema enhancement New feature or enhancement server Related to backend workings (Django/Rest API) stale an issue lacking activity
Milestone
Backlog

Comments

@dpgraham4401
Copy link
Member

dpgraham4401 commented Feb 16, 2023 •
edited
Loading

This is a feature requests that will allow haztrak to store RCRA management method codes (MMC) in its db instead of retrieving from RCRAInfo. MMC should not be hard coded in (for examples as options) because it is possible for them to change over time. With that being said, change should be rare and for the scope of this project, a PR could resolve this issue with the following..

  • A new model definition (MethodCode)
  • A new ModelSerializer (MethodCodeSerializer)
  • Fixtures data migration

Fixtures would be required (to resolve this PR) unless the following are also implemented.

  • A new use case in our service layer (exposed as a method on LookupService) that pulls the MMC.
  • A Celery task that invokes this use case
@dpgraham4401 dpgraham4401 mentioned this issue Feb 16, 2023
Closed
9 tasks
@dpgraham4401 dpgraham4401 added enhancement New feature or enhancement help wanted Extra attention is needed good first issue Good for newcomers server Related to backend workings (Django/Rest API) database changes that require modification to the database schema and removed help wanted Extra attention is needed good first issue Good for newcomers labels Feb 16, 2023
@dpgraham4401 dpgraham4401 changed the title Pull Management Method Codes RCRA Management Method Codes Feb 16, 2023
@dpgraham4401 dpgraham4401 added this to the Quicker Sign milestone Feb 28, 2023
@dpgraham4401 dpgraham4401 modified the milestones: Quicker Sign, Backlog Mar 25, 2023
@dpgraham4401 dpgraham4401 added the stale an issue lacking activity label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database changes that require modification to the database schema enhancement New feature or enhancement server Related to backend workings (Django/Rest API) stale an issue lacking activity
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@dpgraham4401