Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra lines in summary file with large number of samples #344

Closed
garfinjm opened this issue Jun 27, 2024 · 5 comments · Fixed by #347
Closed

Extra lines in summary file with large number of samples #344

garfinjm opened this issue Jun 27, 2024 · 5 comments · Fixed by #347

Comments

@garfinjm
Copy link

Hello again!

I'm encountering an issue where extra lines are added to the cecret_results.csv file when a large number (hundreds) of samples are run together.

Basically, I get two extra lines in my cecret_results.csv that look like:

name,name,,,p/f,,,,,,,,model,alerts,,,,,,,,,,,,,,,,,,,,,,v3.14.240610,artic 1.2.4
seq,seq,,,best,,,,,,,,seq,,,,,,,,,,,,,,,,,,,,,,,v3.14.240610,artic 1.2.4

This only seems to happen when I run large batches of samples through together. I've tracked these extra lines back to the vadr.sqa file used during the cecret summary process (see: ncbi/vadr#81)

I think one possible fix would be to edit the line below replacing grep -v "#-" with grep -v "^#"" (as Eric suggests in the vadr issue).

if [ -s "vadr.vadr.sqa" ] ; then tail -n +2 "vadr.vadr.sqa" | grep -v "#-" | tr -s '[:blank:]' ',' > vadr.csv ; fi

Let me know if you need any other info or want me to try something else on my setup, and thanks again for all your work on Cecret.

@erinyoung
Copy link
Member

Oh SNAP!

@erinyoung
Copy link
Member

FYI, I'm working on this today

@erinyoung
Copy link
Member

I actually need the vadr header, but the latest set of updates that are currently going through testing should fix the issue you are seeing.

Thank you for bringing this to my attention!

@erinyoung
Copy link
Member

This issue should be fixed now!!!

@garfinjm
Copy link
Author

Works perfect, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants