From cfd7d6552e167d70d67666e43e16f955c360e555 Mon Sep 17 00:00:00 2001
From: Jin Igarashi <igarashi.jin@water-gis.com>
Date: Tue, 9 Apr 2024 18:55:00 +0900
Subject: [PATCH] fix: set default threshold to 0.1 and merged datam and
 threahold mask into one (#92)

---
 src/cogserver/algorithms/rca.py | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/cogserver/algorithms/rca.py b/src/cogserver/algorithms/rca.py
index cc73a02..cbabec0 100644
--- a/src/cogserver/algorithms/rca.py
+++ b/src/cogserver/algorithms/rca.py
@@ -21,7 +21,7 @@ class RapidChangeAssessment(BaseAlgorithm):
     """Rapid change assessment."""
     # parameters
     threshold: float = Field(
-        default=0.5, ge=0.1, le=1.0,
+        default=0.1, ge=0.1, le=1.0,
         title="Threshold(%)",
         description="Only pixels with change above this threshold will be returned"
     )
@@ -76,13 +76,8 @@ def __call__(self, img: ImageData) -> ImageData:
         valid_mask = (img.array[2].astype('uint8') > self.cloud_mask_value) | (img.array[3].astype('uint8') > self.cloud_mask_value)
         diff = b2-b1
         data = diff
-        v = 0.1
-        #v = data.ptp()*.1
-        datam = (data > -v) & (data < v)
+        datam = (data > -self.threshold) & (data < self.threshold)
         valid_mask |= datam
-        if self.threshold:
-            threshold_mask = np.abs(data)< self.threshold
-            valid_mask |= threshold_mask
 
         arr = numpy.ma.masked_array(data*100, dtype=self.output_dtype, mask=valid_mask)
         return ImageData(