Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE-EPI T1 Acquisition Orders #238

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

alexdaniel654
Copy link
Member

Proposed changes

Currently ukat only supports ascending slice acquisition orders i.e. ukat assumes the zeroth slice was acquired first, next slice tss later, the next slice 2 x tss later etc. This isn't always the case. In descending acquisitions, the -1th slice is acquired first, the -2th slice tss later etc and in centric acquisitions the slice acquisition order is [4, 2, 0, 1, 3] for a five slice acquisition. ukat should support these options and, ideally, custom acquisition orders.

Checklists

  • I have read and followed the CONTRIBUTING document
  • This pull request is from and to the dev branch
  • I have added tests that demonstrate the feature/fix works
  • I have added necessary documentation (if appropriate)
  • I have updated documentation which becomes obsolete after my changes (if appropriate)
  • I have added/updated a notebook to demonstrate the changes (if appropriate)
  • Files added follow the repository structure (if appropriate)

This was linked to issues Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (d2b78c9) to head (2a866a0).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #238      +/-   ##
==========================================
+ Coverage   97.94%   97.97%   +0.02%     
==========================================
  Files          48       48              
  Lines        4534     4588      +54     
==========================================
+ Hits         4441     4495      +54     
  Misses         93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexdaniel654 alexdaniel654 merged commit f5c4b2a into UKRIN-MAPS:dev Feb 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T1 acquisition orders MOLLI correction factor
1 participant