Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change T1 model selection to be an explicit flag rather than automatic #225

Open
alexdaniel654 opened this issue Sep 27, 2024 · 0 comments · Fixed by #227
Open

Change T1 model selection to be an explicit flag rather than automatic #225

alexdaniel654 opened this issue Sep 27, 2024 · 0 comments · Fixed by #227
Assignees
Labels
type:enhancement 🛠️ Improvements to existing features
Milestone

Comments

@alexdaniel654
Copy link
Member

Pre-processing steps (registration, EPI distortion correction etc) can often cause quite a lot of slightly negative numbers, this then means the T1 mapping code assumes the data has been magnitude corrected. After multiple people have had issues when trying to debug this behaviour we've decided it makes sense to add a flag when instantiating the class to select if the data should be fit to a magnitude corrected model or absolute model.
I'd suggest the automatic selection is kept as an option (not default) but the threshold for deciding the data has been magnitude corrected (currently if 1% of voxels in the first TI are negative) should be increased so it requires more voxels and ideals a larger magnitude of negative numbers.

@alexdaniel654 alexdaniel654 added the type:enhancement 🛠️ Improvements to existing features label Sep 27, 2024
@alexdaniel654 alexdaniel654 added this to the v0.8.0 milestone Sep 27, 2024
@alexdaniel654 alexdaniel654 self-assigned this Sep 27, 2024
@alexdaniel654 alexdaniel654 linked a pull request Sep 30, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement 🛠️ Improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant