Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update step indicator total pages when a user forks #16

Open
JoeChapman opened this issue Apr 5, 2016 · 2 comments
Open

Update step indicator total pages when a user forks #16

JoeChapman opened this issue Apr 5, 2016 · 2 comments
Labels
enhancement

Comments

@JoeChapman
Copy link
Contributor

When a user forks it can change the number of remaining pages in their journey. I would like to be able to reflect this in a step indicator view parameter
joefitter added a commit that referenced this issue May 3, 2016
@joefitter
Closes #16 - Added step-progress middleware to baseController
91cfbc8 
* Added new step progress middleware which adds a stepData object to the sessionModel
* stepData contains currentStep, totalSteps, stepsJourney and prevStep
* prevStep - records current step for use in working out index of next step when next called
* stepJourney - actual journey of steps in order
* currentStep - 1-indexed step number to display - index of step in stepsJourney
* totalSteps - total number of steps taking visited forks into account
* mocked SessionModel for tests
joefitter added a commit that referenced this issue May 4, 2016
@joefitter
Closes #16 - Added step-progress middleware to baseController
9b31b0d 
* Added new step progress middleware which adds a stepData object to the sessionModel
* stepData contains currentStep, totalSteps, stepsJourney and prevStep
* prevStep - records current step for use in working out index of next step when next called
* stepJourney - actual journey of steps in order
* currentStep - 1-indexed step number to display - index of step in stepsJourney
* totalSteps - total number of steps taking visited forks into account
* mocked SessionModel for tests
@JoeChapman
Copy link
Contributor Author

@UKHomeOffice/hof after some chat and https://www.gov.uk/service-manual/user-centred-design/resources/patterns/progress-indicators.html#section-3 I think we should conclude that this is not a thing we should be concerned with. Instead where journeys lengths may be dynamic a different solution for indicating the users' whereabouts should be designed

@joefitter joefitter reopened this May 20, 2016
@joefitter
Copy link
Contributor

After further discussion the initial solution will be to display the index of the current step, but not show how many steps there are in total (as this may change). This should take into account re-visiting a step, and when steps are invalidated (it shouldn't skip)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoeChapman @joefitter