Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we always publish #12

Open
elduddz opened this issue Nov 22, 2019 · 3 comments
Open

should we always publish #12

elduddz opened this issue Nov 22, 2019 · 3 comments

Comments

@elduddz
Copy link
Contributor

elduddz commented Nov 22, 2019

just a thought that we should always output a container, maybe flag a branch build as unstable some how?

@eganjs
Copy link
Contributor

eganjs commented Nov 22, 2019

A step could be added that only runs when it's not on master and push an image with the branch in the tag

I would suggest {YYYY-MM-DD}-{branch-name} for the tag, including the commit hash is probably unnecessary here

It's worth noting that resolving the branch name in Azure DevOps is not a simple task as I believe the branch is checked out by commit hash so can not be resolved through git easily

This change of tag for branches would probably require the introduction of another Makefile rule

@elduddz
Copy link
Contributor Author

elduddz commented Nov 23, 2019

This change of tag for branches would probably require the introduction of another Makefile rule
😣

I've seen others with test and stable used? Is latest always defaulted to the last push/pull so could be a build from a branch?

@eganjs
Copy link
Contributor

eganjs commented Nov 29, 2019

#15 May make this easier to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants