Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in Corr #45

Open
shounakbhogale opened this issue Mar 7, 2018 · 1 comment
Open

Problem in Corr #45

shounakbhogale opened this issue Mar 7, 2018 · 1 comment
Labels

Comments

@shounakbhogale
Copy link

shounakbhogale commented Mar 7, 2018

The correlation coefficient objective function gives 'nan' error probably because of division by zero error.

Bryan came up with these changes quickly:

Tools.cpp - line 994 : double corr_xy = cov_xy / sqrt( x_var * y_var + 0.000001 );
ObjFunc.cpp - line 36 : totalSim += abs( corr( prediction[i], ground_truth[i] ) );

@bryan-lunt bryan-lunt added the bug label Mar 7, 2018
@bryan-lunt
Copy link
Contributor

The second change should be added to the main code immediately.
The first, the whitening in Tools.cpp, might be done differently, with like a soft-min or an if or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants