Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dates for creators map as "single" dates even though most are ranges #27

Open
graykr opened this issue Jan 8, 2025 · 0 comments
Open
Labels
creator record issues related to the creator record (called agent record in aspace)

Comments

@graykr
Copy link

graykr commented Jan 8, 2025

I am not sure if there is an implication now, but it seems like there could be for the future use of this data.

Can we test the date expression to see if it looks like a range, and if so, put it in as a range? Ideally we'd also populate the normal date information for the date expression.

Here is the relevant source code:

if(record.has("Dates") && !record.getString("Dates").isEmpty()) {
            JSONArray datesJA = new JSONArray();
            JSONObject dateJS = new JSONObject();
            dateJS.put("date_type", "single");
            dateJS.put("label", "existence");
            dateJS.put("expression", record.get("Dates"));
            datesJA.put(dateJS);
            agentJS.put("dates_of_existence", datesJA);
        }

https://github.com/archivesspace/archon-migration/blob/5ab5bc4aed3607a71923ec91e0a515680c361f7b/src/org/nyu/edu/dlts/utils/ASpaceMapper.java#L417C9-L425C10

@graykr graykr added the creator record issues related to the creator record (called agent record in aspace) label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
creator record issues related to the creator record (called agent record in aspace)
Projects
None yet
Development

No branches or pull requests

1 participant