public biographical info on creators in archon is migrating as an unpublished note

[graykr]

It looks like the addTextNote function (which is called from the inappropriately named "addBiologicalHistoryNote" function... it should be biographical...) is looking for a "publishRecord" variable ... which is defined at the top as false for some reason??

private Boolean publishRecord = false;
https://github.com/archivesspace/archon-migration/blob/5ab5bc4aed3607a71923ec91e0a515680c361f7b/src/org/nyu/edu/dlts/utils/ASpaceMapper.java#L63

private void addTextNote(JSONObject noteJS, String content) throws Exception {
        noteJS.put("jsonmodel_type", "note_text");
        noteJS.put("publish", publishRecord);
        noteJS.put("content", content);
    }

https://github.com/archivesspace/archon-migration/blob/5ab5bc4aed3607a71923ec91e0a515680c361f7b/src/org/nyu/edu/dlts/utils/ASpaceMapper.java#L1486

It looks like for convertDigitalObject function, the convertCollection function, and convertCollectionContent this variable is changed based on whether the digital content is enabled or not:
For example:
publishRecord = convertToBoolean(record.getInt("Browsable"));
https://github.com/archivesspace/archon-migration/blob/5ab5bc4aed3607a71923ec91e0a515680c361f7b/src/org/nyu/edu/dlts/utils/ASpaceMapper.java#L783

Since creators cannot be made private in Archon, I think within the convertCreator function, publishRecord should be set to true.
Perhaps instead of:
agentJS.put("publish", true);
https://github.com/archivesspace/archon-migration/blob/5ab5bc4aed3607a71923ec91e0a515680c361f7b/src/org/nyu/edu/dlts/utils/ASpaceMapper.java#L405

We should have something like:

publishRecord = true; //all creators are public in Archon
agentJS.put("publish", publishRecord);

This would better mirror the other "convert" functions, and the changed value should carry through the successive function calls within the convertCreator function like it does for the other convert functions.