Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returned 'removed_indexes' in transition function in class TabularGrowthRateTransition may be missing rows that are in 'data', but not in returned 'updated'. #207

Open
stefancoe opened this issue Feb 13, 2018 · 3 comments

Comments

@stefancoe
Copy link

Please see this issue on our repo that describes the problem:

psrc/urbansim2#123

@hanase
Copy link
Contributor

hanase commented Feb 13, 2018

Just to follow up on the issue Stefan found. The problem happens when some rows of the data (say households) have characteristics that are not captured by the control totals table. These can be some outlier agents from the base year that we don't want to control for and should be removed. However, the link tables (say persons) do not remove rows belonging to these outlier agents.

@stefancoe
Copy link
Author

stefancoe commented Feb 13, 2018

Yes- it turns out the missing households have an income of 49,999 or 74,999 so this is a problem with our control totals. But maybe a warning is warranted?

@janowicz
Copy link
Contributor

Thanks for reporting this. Good to know that it was a control total issue. Agreed that a warning about some agents not being subject to the transition model would be a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants