Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Excel files to CSV - Uncategorised files #1563

Merged
merged 15 commits into from
Jan 15, 2025

Conversation

mnjowe
Copy link
Collaborator

@mnjowe mnjowe commented Jan 7, 2025

This PR converts all excel files that haven't been included in the previous PR's on the same.

@mnjowe mnjowe self-assigned this Jan 7, 2025
@mnjowe
Copy link
Collaborator Author

mnjowe commented Jan 8, 2025

Hi @tamuri or @tbhallett. Do you have an idea of what is causing the documentation fail? you can scroll down the details page for more details. I can't understand exactly where the error is coming from

@tamuri
Copy link
Collaborator

tamuri commented Jan 8, 2025

The error is pandas.errors.EmptyDataError: No columns to parse from file - perhaps one of the new files you've created is empty?

@mnjowe
Copy link
Collaborator Author

mnjowe commented Jan 8, 2025

I see. Thanks @tamuri , indeed there is a file structure.csv in Resourcefile_Lifestyle_Enhanced folder that's empty. I looked at the original sheet in the excel file(Resourcefile_Lifestyle_Enhanced.xlsx) and shows it has diagrams only(see the attached). May be that's the reason these couldn't be read and added to structure.csv?

Since we have the original excel file in sharepoint, I will delete this file here and see if that resolves the issue.

Screenshot 2025-01-08 at 12 56 39

Copy link
Collaborator

@tbhallett tbhallett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems fine to me @mnjowe

The tricky one is obviously get_parameters_for_improved_healthsystem_and_healthcare_seeking()

Please could you confirm that the resulting dict in that test is EXACTLY the same when using the csv's as when using the original xlsx?

@mnjowe
Copy link
Collaborator Author

mnjowe commented Jan 9, 2025

@tbhallett, let me check

@mnjowe
Copy link
Collaborator Author

mnjowe commented Jan 10, 2025

@tbhallett. I did the checking by running same test from this brach and master. They output seems similar(see the two logs below)
output_master.log
output.log

@tamuri tamuri merged commit 4f161e3 into master Jan 15, 2025
62 checks passed
@tamuri tamuri deleted the mnjowe/any_other_excel_files branch January 15, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants