-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Excel files to CSV - Uncategorised files #1563
Conversation
Hi @tamuri or @tbhallett. Do you have an idea of what is causing the documentation fail? you can scroll down the details page for more details. I can't understand exactly where the error is coming from |
The error is |
I see. Thanks @tamuri , indeed there is a file Since we have the original excel file in sharepoint, I will delete this file here and see if that resolves the issue. |
…to mnjowe/any_other_excel_files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems fine to me @mnjowe
The tricky one is obviously get_parameters_for_improved_healthsystem_and_healthcare_seeking()
Please could you confirm that the resulting dict
in that test is EXACTLY the same when using the csv's as when using the original xlsx?
@tbhallett, let me check |
@tbhallett. I did the checking by running same test from this brach and master. They output seems similar(see the two logs below) |
This PR converts all excel files that haven't been included in the previous PR's on the same.