Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw JSON returned after clicking "Cancel This Instance" button during a send #86

Open
cjg89 opened this issue Sep 9, 2020 · 1 comment
Assignees
Labels
bug A problem with existing functionality

Comments

@cjg89
Copy link
Member

cjg89 commented Sep 9, 2020

This may have been a fluke/oddity due to DSO Prod's DB seemingly being copied over from current-Prod while an email was sending, but when I attempted to cancel the stuck sending instance in DSO Prod by clicking the "cancel this instance" button on the single instance view, I got a raw JSON success message.

We'd need to test a send cancel against a running email send to confirm whether or not this is still happening.

@cjg89 cjg89 added the bug A problem with existing functionality label Sep 9, 2020
@jmbarne3
Copy link
Contributor

jmbarne3 commented Sep 9, 2020

The relevant code: https://github.com/UCF/PostMaster/blob/master/manager/views.py#L483-L510

It looks like the view is setup to work from the dashboard, but not from the single instance view. I believe in the dashboard, some javascript posts to the view to cancel the send, and then the response is processed and puts a message on the screen. We probably need to just add in some additional logic that reloads the instance view with an info message.

I think the issue currently exists in PROD and is not related to the DSO migration. We've just never come across it, probably because all of our cancellations have been done from the dashboard view.

@cjg89 cjg89 changed the title (Maybe bug?) Raw JSON returned after clicking "Cancel This Instance" button during a send Raw JSON returned after clicking "Cancel This Instance" button during a send Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem with existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants