Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split degree-search.js into its own minified file, and enqueue dependent on UCF Degree Search typeahead js #120

Open
cjg89 opened this issue Feb 10, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@cjg89
Copy link
Member

cjg89 commented Feb 10, 2021

Description

Split degree-search.js into its own, separately enqueued script, and enqueue it using the Degree Search plugin's ucf_degree_search_enqueue_scripts_after hook (UCF/UCF-Degree-Search-Plugin#93).

Why it's Important

Doing this will reduce the amount of JS loaded on each page to improve performance, and ensures that this logic is enqueued in the correct order with dependent scripts in place.

Alternatives

n/a

Possible Implementation

n/a

Additional context

See UCF/Main-Site-Theme@44efd83 as an example implementation.

@cjg89 cjg89 added the enhancement New feature or request label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants