Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m_noJVTVeto and m_dofJVTVeto are not implemented consistently and can easily lead to confusion #1684

Open
tofitsch opened this issue Apr 12, 2024 · 0 comments
Assignees

Comments

@tofitsch
Copy link
Contributor

In JetSelector both for JVT and fJVT there is the option only to decorate the (f)JVT decision to the jet rather than actually rejecting jets failing this criterion.

The options for this are called m_noJVTVeto and m_dofJVTVeto. Note the do rather than no in fJVT. Therefore these options work in opposite ways. This can easily lead to confusions and should be made consistent (both no or both do).

@tofitsch tofitsch self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant