Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML2 TA Feedback #25

Open
afshinamini opened this issue Jan 31, 2021 · 2 comments
Open

ML2 TA Feedback #25

afshinamini opened this issue Jan 31, 2021 · 2 comments

Comments

@afshinamini
Copy link

Hi Folks,

Good job on the dashboard! It's easy to use and informative. Few comments:

  • Adjust the title to the center of page.
  • add some space between title and the rest of dashboard. You have plenty of space.
  • Add units for "Monthly income".
  • It would be nice to see the stats for all genders combined. So maybe add a "All" option in gender dropdown menu.

Cheers,
Afshin

@ssyayayy
Copy link
Collaborator

Hi Afshin,
Thanks a lot for providing your valuable feedback! I'm afraid we will have to work on these implements in milestone 4 due to the timing of receiving the feedback. Is that ok?

@ssyayayy
Copy link
Collaborator

ssyayayy commented Feb 6, 2021

Hi Afshin,
We have addressed them all in the new release. Here is a summary for tracking purpose.

  • Adjust the title to the center of page.
  • add some space between title and the rest of dashboard. You have plenty of space.
  • Add units for "Monthly income".
  • It would be nice to see the stats for all genders combined. So maybe add a "All" option in gender dropdown menu.

Additional comments on the last one: Instead of adding an option for "all", we implemented the change by enabling multiple selection so the users could add all one at a time from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants