Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Sometimes API requests fail but retry doesn't work #88

Open
1 task done
zoidy opened this issue Oct 27, 2023 · 0 comments
Open
1 task done

Bug: Sometimes API requests fail but retry doesn't work #88

zoidy opened this issue Oct 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@zoidy
Copy link
Collaborator

zoidy commented Oct 27, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

Sometimes, API requests fail and the code will retry. However, the retry attempt sometimes produces unexpected results. For example, during the item fetching stage, if a timeout error occurs, the code will retry but instead, the item fetching process stops as if there were no more items to fetch.

This issue may be fixed by implementing more robust retry code. Instead of the existing solution, use the built-in retry functionality of the requests library. This was already implemented for file download retries in #83. This issue is to implement the same for all uses of the requests library.

Steps To Reproduce

See above.

@zoidy zoidy added the bug Something isn't working label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant