refactor: simplify query params

Author: jepser

src/utils.js

@@ -22,17 +22,8 @@ export const createMemberPatchQuery = ({ members, operation }) => {
 
 export const buildUrlWithParams = (url, params = {}) => {
   const queryParams = Object.keys(params)
-    .reduce((list, key) => {
-      const currentValue = params[key]
-      if (currentValue !== undefined && currentValue !== null) {
-        return [
-          ...list,
-          `${encodeURIComponent(key)}=${encodeURIComponent(currentValue)}`
-        ]
-      } else {
-        return list
-      }
-    }, [])
+    .filter((k) => params[k] !== undefined && params[k] !== null)
+    .map(k => `${encodeURIComponent(k)}=${encodeURIComponent(params[k])}`)
     .join('&')
 
   return queryParams ? `${url}?${queryParams}` : url

tests/unit/utils.test.js

@@ -23,7 +23,7 @@ test('parameters should be enconded', () => {
   expect(buildUrlWithParams(url, params)).toBe('http://typeform.com?a=%401&b=%232')
 })
 
-test.only('undefined values for parameter will be skipped', () => {
+test('undefined values for parameter will be skipped', () => {
   const url = 'http://typeform.com'
   const params = {
     a: '@1',
@@ -32,7 +32,7 @@ test.only('undefined values for parameter will be skipped', () => {
   expect(buildUrlWithParams(url, params)).toBe('http://typeform.com?a=%401')
 })
 
-test.only('falsy values should be passed', () => {
+test('falsy values should be passed', () => {
   const url = 'http://typeform.com'
   const params = {
     a: '0',