Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaving unclosed files when signing/veryfying #10

Open
tpazderka opened this issue May 24, 2021 · 0 comments
Open

Leaving unclosed files when signing/veryfying #10

tpazderka opened this issue May 24, 2021 · 0 comments

Comments

@tpazderka
Copy link

Code in module pycsob.utils is leaving unclosed files after verification/signing. The files should be closed when no longer needed.

with open(pubkeyfile) as a:
    key = RSA.importKey(a.read())

pycsob/pycsob/utils.py

Line 21 in aff5c8d

key = RSA.importKey(open(keyfile).read())

pycsob/pycsob/utils.py

Line 29 in aff5c8d

key = RSA.importKey(open(pubkeyfile).read())

JiriKr added a commit to olc-systems-sro/pycsob that referenced this issue Apr 5, 2022
@JiriKr
fixed TwistoPayments#10
a8efe07
zbohm pushed a commit to zbohm/pycsob that referenced this issue Jul 22, 2022
@JiriKr @zbohm
fixed TwistoPayments#10
a142130
@zbohm zbohm mentioned this issue Jul 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpazderka