Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Setup #1

Open
14 of 19 tasks
AndreasNasman opened this issue Mar 7, 2021 · 6 comments
Open
14 of 19 tasks

(Feature) Setup #1

AndreasNasman opened this issue Mar 7, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@AndreasNasman
Copy link
Member

AndreasNasman commented Mar 7, 2021

Detailed Description

General

Formatting and linting

PWA

Testing

Clean up

  • Remove all eslint-disables, if possible
  • Prefer named exports, potentially in a index.ts file

Disregarded

  • Change from npm to yarn No advantage of using yarn, at least for our use case.
  • Add stylelint No need (at least initially) since we want to use Tailwind CSS.
  • index.html title reference Seldom you want the index.html to be the same as the name in package.json.

Context

It's easier to develop once all this stuff is in place.

Possible Implementation

Complete all tasks above.

@create-issue-branch
Copy link

Branch issue-1-Setup created!

@dusan-turajlic
Copy link
Member

dusan-turajlic commented Mar 29, 2021

Run lint, formatting, and compilation before commits.

Why? I would rather change that to setup github action for linting. I'm not a fan of tasks running when I do my commits

@dusan-turajlic
Copy link
Member

Change from npm to yarn

Is there a reason for this? IDK but I have kinda just been sticking with NPM for most of my tasks lately and have not encounterd any issues

@dusan-turajlic
Copy link
Member

Also should this maybe be split in to a few issues. Some of these can be done in pararell.

@dusan-turajlic dusan-turajlic linked a pull request Mar 29, 2021 that will close this issue
@AndreasNasman
Copy link
Member Author

AndreasNasman commented Apr 2, 2021

Run lint, formatting, and compilation before commits.

Why? I would rather change that to setup github action for linting. I'm not a fan of tasks running when I do my commits

I agree that there should be GitHub action checking this, but I like to catch errors and warnings as soon as possible, so that's why I like having formatting and linting checks on pre-commit Git hooks. Not sure what's the easiest way to have this conveniently be turned on and off according to preferences. 🤔

Change from npm to yarn

Is there a reason for this? IDK but I have kinda just been sticking with NPM for most of my tasks lately and have not encounterd any issues

Not sure why I put this here, npm is fine for me too! 👍

Also should this maybe be split in to a few issues. Some of these can be done in pararell.

I kinda want to do this myself in one go as I'm going to document this process – might put post migration process online somewhere too – and use it at work if possible. 🙂 Most of the items on the checklist are minor issues anyway; connecting them all is a bit more tricky.

@dusan-turajlic dusan-turajlic changed the title Setup (Feature) Setup Apr 4, 2021
@dusan-turajlic dusan-turajlic added the enhancement New feature or request label Apr 4, 2021
@AndreasNasman
Copy link
Member Author

Chosen Vue CLI options for reference
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants