Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User login lost when a HIT opens simultaneously in multiple tabs #37

Open
mizzao opened this issue Aug 17, 2015 · 1 comment
Open

User login lost when a HIT opens simultaneously in multiple tabs #37

mizzao opened this issue Aug 17, 2015 · 1 comment
Labels

Comments

@mizzao
Copy link
Member

mizzao commented Aug 17, 2015

Originally reported by @ldworkin. Seems like something like the following happens (more likely when a HIT is banked):

  • User opens HIT from dashboard (1)
  • User accidentally opens the same HIT in a separate tab, from dashboard (2)
  • HIT 1 authenticates and stores login token to local storage
  • HIT 2 authenticates but does not see the local storage token from HIT 1, as that is on a 3 second poll
  • HIT 2 overwrites the login token in local storage, causing HIT 1 to log out and be unresponsive

A workaround is to tell users not to open the HIT in multiple tabs, but we should make this more robust. It does seem like Meteor in general is less likely to observe this issue because there is no URL-generated auto login. It is a rather edge case when two URL logins are opened nearly simultaneously.

@mizzao mizzao changed the title Issues when a HIT is open in multiple tabs User login lost when a HIT is open in multiple tabs Aug 17, 2015
@mizzao mizzao self-assigned this Aug 17, 2015
@mizzao mizzao added the bug label Aug 17, 2015
@mizzao mizzao changed the title User login lost when a HIT is open in multiple tabs User login lost when a HIT opens simultaneously in multiple tabs Aug 17, 2015
@mizzao
Copy link
Member Author

mizzao commented Aug 19, 2015

Seems like this might not be due to the polling issue, as it happens even if a second tab is opened much later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant