Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more synthetic targets #20

Merged
merged 23 commits into from
Aug 23, 2023
Merged

add more synthetic targets #20

merged 23 commits into from
Aug 23, 2023

Conversation

zuhengxu
Copy link
Member

@zuhengxu zuhengxu commented Jul 18, 2023 •
edited
Loading

as per issue #14

  • synthetic examples that are challenging to sample
    • Banana
    • Cross distribution
    • warped Gaussian
    • neal's funnel

@zuhengxu zuhengxu self-assigned this Jul 18, 2023
torfjelde
torfjelde reviewed Jul 19, 2023
View reviewed changes
example/targets/cross.jl Outdated Show resolved Hide resolved
torfjelde
torfjelde reviewed Jul 19, 2023
View reviewed changes
example/targets/cross.jl Outdated Show resolved Hide resolved
@zuhengxu zuhengxu requested a review from torfjelde July 26, 2023 17:10
torfjelde
torfjelde requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff:) A few comments though that I think should be resolved before we hit the big green button 👍

example/targets/cross.jl Show resolved Hide resolved
example/targets/neal_funnel.jl Outdated Show resolved Hide resolved
example/targets/neal_funnel.jl Outdated Show resolved Hide resolved
example/targets/neal_funnel.jl Outdated Show resolved Hide resolved
example/targets/neal_funnel.jl Outdated Show resolved Hide resolved
example/targets/warped_gaussian.jl Outdated Show resolved Hide resolved
example/targets/warped_gaussian.jl Outdated Show resolved Hide resolved
example/targets/warped_gaussian.jl Outdated Show resolved Hide resolved
example/targets/cross.jl Show resolved Hide resolved
example/targets/cross.jl Outdated Show resolved Hide resolved
@zuhengxu
Copy link
Member Author

I think the previous mentioned issues are fixed. @torfjelde Can you take another skim before I hit the "big green button"?

torfjelde
torfjelde approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, once again @zuhengxu :)

I've added a few final comments, but those should just be easy accepts of my proposed solution I believe.

example/targets/cross.jl Outdated Show resolved Hide resolved
example/targets/cross.jl Outdated Show resolved Hide resolved
example/targets/neal_funnel.jl Outdated Show resolved Hide resolved
@yebai yebai merged commit 43c06ab into TuringLang:main Aug 23, 2023
3 checks passed
@torfjelde
Copy link
Member

Ah sorry, I didn't make it clear that you could just hit the big green button once the comments had been addresed (or did my review end up being marked as stale?)!

@zuhengxu
Copy link
Member Author

Ah sorry, I didn't make it clear that you could just hit the big green button once the comments had been addresed (or did my review end up being marked as stale?)!

All good! All review suggestions are committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunxd3 sunxd3 Awaiting requested review from sunxd3

@torfjelde torfjelde Awaiting requested review from torfjelde

Assignees

@zuhengxu zuhengxu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuhengxu @torfjelde @yebai