Better names for sampling methods from trees

[xukai92]

See 26aabb5#commitcomment-34976303

[xukai92]

Related discussion: #91 (comment)

[yebai]

Maybe we can remove Slice and Multinomial from exports? These exports are only useful for expert-users, so we might not want to export them anyway.

[xukai92]

I prefer to rename them for several reasons.

• Users have to use AdvancedHMC.Slice if we don't export them.
• AdvancedHMC IS for "expert-users".

Some options:

1. Go for the simplicity: Multinomial -> Multi
2. Go for self-contained: TrajectoryMultinomialSampler and TrajectorySliceSampler

Any thoughts?

[xukai92]

Option 3:

Define @enum TrajectorySampler slice multinomial and somehow dispatch over them. (Might be tricky?)

[yebai]

I mean in most cases we will use the default NUTS configuration, so maybe it’s ok to remove Slice/Multinomial from exports. Also, the user can still explicitly import these names if needed. Then we can consider creating a sugar syntax, e.g. NUTS(...) will create a NUTS sampler with Multinomial sampler by default.

[yebai]

Alternatively, we can shorten SliceTrajectorySampler to SliceTS, similarly MultinomialTS and MetropolisTS. The meanings of these types should be clear from their common supertype AbstractTrajectorySampler.

[xukai92]

I like this ???TS proposal! Let's do this.

[yebai]

Closed by #114.