Skip to content

[low severity] toJSON API incompatible warning #225

Closed
@FurryR

Description

@FurryR

toJSON (optTargetId, serializationOptions) {

Conflicts with:

92c53a5

Which may cause some programs break.

Possible solution:

    /**
     * Export project or sprite as a Scratch 3.0 JSON representation.
     * @param {*} optSerializationOptions Optional id of a sprite to serialize, or the serialization option
     * @param {*} optCompatibleOptions Compatible serialization option
     * @return {string} Serialized state of the runtime.
     */
    toJSON (optSerializationOptions, optCompatibleOptions) {
        const sb3 = require('./serialization/sb3');
        let serializationOptions = optSerializationOptions;
        let targetId;
        if (typeof optSerializationOptions === 'string') {
           serializationOptions = optCompatibleOptions;
           targetId = optSerializationOptions;
        } else {
           serializationOptions = optSerializationOptions;
           if (typeof serializationOptions === 'object' && serializationOptions) targetId = serializationOptions.targetId;
        }
        return StringUtil.stringify(sb3.serialize(this.runtime, targetId, serializationOptions);
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions