Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] | Check if Users using 'chr21' or '21' notation in input VCFs #12

Open
G-kodes opened this issue Sep 14, 2021 · 1 comment
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@G-kodes
Copy link
Member

G-kodes commented Sep 14, 2021

Is your feature request related to a problem? Please describe.
Currently, the pipeline does not check if a user is using vcf input with 'chr21' or '21' notation. Plink-2 does explicitly require 'chr21' notation to function so this really should be checked beforehand and converted if needed.

Describe the solution you'd like
Inclusion of additional python scripts in the VALIDATE rule to check notation type and if required, convert it (AWK or SED?).

Describe alternatives you've considered, if any
Not checking and just letting it break? Not gonna lie, not a great alternative...

@G-kodes G-kodes added the enhancement New feature or request label Sep 14, 2021
@G-kodes G-kodes self-assigned this Sep 14, 2021
@G-kodes G-kodes added this to the BETA Release milestone Sep 14, 2021
@G-kodes
Copy link
Member Author

G-kodes commented Nov 16, 2021

Rust might be an ideal, lightweight option for this. It already has promising libraries for VCF parsing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant