Skip to content

Commit 61a6210

Browse files
sjg20xypron
authored andcommitted
video: Add a note about the broken implementation
The cls command is broken. Previous discussion about this was at [1] and [2]. For now, add a note to the source code. [1] https://patchwork.ozlabs.org/project/uboot/patch/ [email protected]/ [2] https://patchwork.ozlabs.org/project/uboot/patch/ [email protected]/ Signed-off-by: Simon Glass <[email protected]>
1 parent b7adb69 commit 61a6210

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

cmd/cls.c

+7-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,13 @@ static int do_video_clear(struct cmd_tbl *cmdtp, int flag, int argc,
1717
{
1818
__maybe_unused struct udevice *dev;
1919

20-
/* Send clear screen and home */
20+
/*
21+
* Send clear screen and home
22+
*
23+
* FIXME(Heinrich Schuchardt <[email protected]>): This should go
24+
* through an API and only be written to serial terminals, not video
25+
* displays
26+
*/
2127
printf(CSI "2J" CSI "1;1H");
2228
if (IS_ENABLED(CONFIG_VIDEO_ANSI))
2329
return 0;

0 commit comments

Comments
 (0)