Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about code details #48

Open
Xinchengzelin opened this issue Jun 29, 2023 · 3 comments
Open

Some questions about code details #48

Xinchengzelin opened this issue Jun 29, 2023 · 3 comments

Comments

@Xinchengzelin
Copy link

Xinchengzelin commented Jun 29, 2023

I read the code on branch argoverse2, could you help me answer some questions about the code?

  1. dataset_argoverse.py L501 , the code should be like in the following?
lane_type_to_int[LaneType.BIKE] = 2 
lane_type_to_int[LaneType.BUS] = 3
  1. dataset_argoverse.py L527, why the code vectors.append(vector) not in the end of this for loop?
  2. decoder.py L339 loss[i] += F.nll_loss(pred_probs[i].unsqueeze(0), torch.tensor([argmin], device=device)), should the second parameter be torch.tensor([1], device=device)?
  3. dataset_argoverse.py L428 should add:
if len(focal_track.object_states) != 110:
            return None
because some object_states of focal_track is less than 110, or the code won't run. 
  1. argoverse2 didn't train the set_predictor, have you try to train set_predictor? If the performance could be closet to that of offline optimization?
@GentleSmile
Copy link
Member

  1. Thanks for pointing it out!
  2. This produces the same results as placing in the end of the loop
  3. Why "1"? "Argmin" indicates the closest predicted trajectory.
  4. If some object_states of focal_track is less than 110, there should be an error. But I have not seen this situation.
  5. We will add set_predictor next week

@Xinchengzelin
Copy link
Author

3. nll_loss

  1. It's my fault
  2. Maybe there is someting wrong with my downloaded data, there are dozens of samples the object_states of focal_track is less than 110. for example these 2 situations: 02ecafff-012c-45f8-bb6e-5ace2c6e3d88 and 014c02b0-3315-4faf-aca5-b239f5b7f0ca, actually 105 frames data.
  3. Looking forward to that

@GentleSmile
Copy link
Member

We found that these two examples 02ecafff-012c-45f8-bb6e-5ace2c6e3d88 and 014c02b0-3315-4faf-aca5-b239f5b7f0ca are both 110 frames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants