-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error for all internal tags #35
Comments
Hmm, seems strange, would you be able to go into more detail? We don't really want to be skipping internal tags since they are very useful for creating custom collections in Eleventy |
The links to /tag/hashtag-(someinternaltag) throw 404s on our live site, so when Eleventy went to fetch them it followed the redirect and wrote to the 404 file. I didn’t change anything with Ghost so I just assumed that the internal tags aren’t publicly browseable. I assume by design, since you don’t really want to expose potentially private metadata like “don’t show this bad post” or whatever. |
Im a bit confused, are you linking to those internal tag pages? Sounds to me like Eleventy is just doing as expected and showing a 404 page on pages that shouldn't exist |
I am not linking to them, this is the default behaviour with this starter out of the box. When I did a build, it generates all the /tag/tagname pages. Since the internal tags all show a 404, Eleventy gives me an error that multiple pages have the same /dist/404.html permalink and fails to build. Steps to reproduce would be, make a ghost site with at least one internal tag. |
@bmann I've proposed a fix which will remove internal tags from the tags collection. Internal tags will still be an attribute on posts, but filtered out when tag pages are created |
Yeah that’s ideal. Thank you! |
I seem to be having a very similar problem. I'm not 100% sure how to confirm this error is coming from the same underlying issue - or go about fixing it. I am using many collections, but no internal tags for pages - instead I am filtering by author for my page collections. config.addCollection("jaPages", async function(collection) {
collection = await api.pagesaz
.browse({
include: "authors",
limit: "all",
filter: "author:ja"
}) and hash-tags for posts
Deploys stopped working suddenly on Netlify yesterday for:
I did try starting with a fresh clone of I could delete all internal tags and reorganize, but since there is this open issue I thought first I should ask for advice. |
Errors on the source site that result in 404s all attempt to write to
dist/404.html
which itself causes the build to fail and nothing to get written.I tracked this down to using internal tags. Since I only had 4 and wasn't really using them, I deleted them. I guess check for internal tags and skip them?
The text was updated successfully, but these errors were encountered: