Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal linking doesn't work in Firefox #21721

Open
1 task done
dkalpakchi opened this issue Nov 25, 2024 · 3 comments
Open
1 task done

Internal linking doesn't work in Firefox #21721

dkalpakchi opened this issue Nov 25, 2024 · 3 comments
Labels
🐛 Bug P3 - Medium [triage] Bugs which we'll fix soon

Comments

@dkalpakchi
Copy link

Issue Summary

When I try add internal links in Ghost admin in Firefox using @ shortcut nothing happens. The expected result is to get Find a post, tag or author menu

Steps to Reproduce

  1. Start a new post in Ghost admin in Firefox
  2. Write @ and see no reaction to this

Ghost Version

5.101.4

Node.js Version

18.15.0

How did you install Ghost?

Via Ghost CLI

Database type

SQLite3

Browser & OS version

Firefox 132.0.2, Ubuntu 24.04.1

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 25, 2024
@sagzy sagzy added 🐛 Bug P3 - Medium [triage] Bugs which we'll fix soon labels Nov 26, 2024 — with Linear
@sagzy
Copy link
Contributor

sagzy commented Nov 26, 2024

Hello @dkalpakchi, thanks for the report! I can reproduce the issue with the provided steps, there seems to be a regression on Firefox. I have pinged the team who worked on Internal Linking to investigate further

@sagzy sagzy removed the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 26, 2024
@ErisDS
Copy link
Member

ErisDS commented Dec 11, 2024

Little update here - this isn't a regression, but rather a long-standing bug with Firefox. Unfortunately the way Firefox fires events is quite different to other browsers.

There's some spike code here which attempted to fix the issue, but it ended up being non-trivial.

A PR fixing this issue would be very welcome 🙏

@dkalpakchi
Copy link
Author

Hi and thanks for the update! As a Firefox user, I would very much like to give it a shot and try fixing the bug. I'm new to the Ghost codebase though, so I'm just learning to find my way around 🙂

I assume you mean a PR to this repo: https://github.com/TryGhost/Koenig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug P3 - Medium [triage] Bugs which we'll fix soon
Projects
None yet
Development

No branches or pull requests

3 participants