Deprecation warning about Project.getConvention() when run using gradle 8.2.1

[AndreasBoehm]

Problem description

The Project.getConvention() method has been deprecated.
This is scheduled to be removed in Gradle 9.0.
Documentation
Plugin: com.github.triplet.play

at org.gradle.api.internal.project.DefaultProject.getConvention(DefaultProject.java:593)	
at com.github.triplet.gradle.play.PlayPublisherPlugin.applyInternal(PlayPublisherPlugin.kt:904)	
at com.github.triplet.gradle.play.PlayPublisherPlugin.access$applyInternal(PlayPublisherPlugin.kt:71)	
at com.github.triplet.gradle.play.PlayPublisherPlugin$apply$2.invoke(PlayPublisherPlugin.kt:87)	
at com.github.triplet.gradle.play.PlayPublisherPlugin$apply$2.invoke(PlayPublisherPlugin.kt:86)	
at com.github.triplet.gradle.play.PlayPublisherPlugin$inlined$sam$i$org_gradle_api_Action$0.execute(DomainObjectCollectionExtensions.kt)	
•••
at com.github.triplet.gradle.play.PlayPublisherPlugin.apply(PlayPublisherPlugin.kt:689)	
at com.github.triplet.gradle.play.PlayPublisherPlugin.apply(PlayPublisherPlugin.kt:71)

Additional context

I used gradle 8.2.1 and Gradle Play Publisher 3.8.4

[github-actions]

This issue has been automatically marked as stale because it has not had recent
activity. It will be closed if no further activity occurs. Thank you for your
contributions.

[AndreasBoehm]

This was closed without being fixed.

[syslogic]

It seems to be the way, how the PlayPublisherExtension is being configured, which possibly can be avoided, when the PlayPublisherExtension knows these default values already; don't .apply {}.

gradle-play-publisher/play/plugin/src/main/kotlin/com/github/triplet/gradle/play/PlayPublisherPlugin.kt

Lines 78 to 88 in df4eadf

	project.extensions.create<PlayPublisherExtension>(PLAY_PATH, "default").apply {
	enabled.convention(true)
	defaultToAppBundles.convention(false)
	commit.convention(true)
	track.convention("internal")
	resolutionStrategy.convention(ResolutionStrategy.FAIL)
	}
	project.plugins.withType<AppPlugin> {
	applyInternal(project)
	}

[edharkhimich]

Any updates on this?

[Goooler]

Fixing this in #1113. I don't see the line in your stacktrace (PlayPublisherPlugin.kt:904), but I guess this is due to

gradle-play-publisher/play/plugin/src/main/kotlin/com/github/triplet/gradle/play/PlayPublisherPlugin.kt

Line 181 in 19dc9a6

val android = project.the<BaseAppModuleExtension>()

check

https://github.com/gradle/gradle/blob/1cf537a851c635c364a4214885f8b9798051175b/subprojects/kotlin-dsl/src/main/kotlin/org/gradle/kotlin/dsl/ProjectExtensions.kt#L100-L112

[SUPERCILEX]

Can someone confirm with snapshot builds that this is fixed? (Those should go out within the hour.)

[PavelSynek]

I confirm that the warning is fixed with snapshot build.